Fixed incorrect unref for gstreamer >= 1.16. #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer is accessed through gst_sample_get_buffer. The buffer shouldn't be unrefed the sample should be, however, this doesn't seem work in gstreamer 1.14. If the buffer is unreffed in 1.16 it eventually causes a segfault.
I tested this fix with gstreamer 1.16 and 1.14, it works with both.