Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ros2 humble cmake error fix #212

Open
wants to merge 2 commits into
base: ros2
Choose a base branch
from

Conversation

knorth55
Copy link
Member

No description provided.

@peterdavidfagan
Copy link

Hi @knorth55,

Thanks for posting this fix.

I am looking to build the package for ROS rolling. I haven't looked too closely into this bug but I presume the current pr depends on changes you proposed in rosidl_python to be merged first?

@knorth55
Copy link
Member Author

@peterdavidfagan yes, you are right.
im waiting that pr to be merged

ros2/rosidl_python#187

@peterdavidfagan
Copy link

Thanks for the confirmation on this @knorth55.

@berndpfrommer
Copy link

Why not move SoundMsgs into its own package (sound_play_msgs)? From what I understand that would work around the bug. Having messages in a separate package is recommended practice anyways.

@knorth55
Copy link
Member Author

knorth55 commented Mar 3, 2024

I dont want to do so because it cause the loss of backward compatibility.
Also, in terms of debian release, it causes a big issue when we have a new package like that at the core of ros package.

In addition, separating msg package is not written in REP, so it should not be forced to any packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants