Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom logic to skip configuration of gripper_controllers on Windows or macOS #1471

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 4, 2025

The gripper_controllers package was disabled on macOS and Windows as it used experimental/optional, but it does not seems to me that the header is used anymore, and I just tried to compile it on Windows and it compiled fine.

Fix #193 .

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (ad7739f) to head (6ad123f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
- Coverage   83.83%   83.82%   -0.01%     
==========================================
  Files         122      122              
  Lines       11120    11121       +1     
  Branches      944      945       +1     
==========================================
  Hits         9322     9322              
  Misses       1489     1489              
- Partials      309      310       +1     
Flag Coverage Δ
unittests 83.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I'm glad that it works. Then let's also export all the symbols as other controllers

gripper_controllers/CMakeLists.txt Show resolved Hide resolved
@traversaro
Copy link
Contributor Author

Awesome. I'm glad that it works. Then let's also export all the symbols as other controllers

Sure, thanks for catching this.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit d86b9d7 into ros-controls:master Jan 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable gripper_controllers on OSX
3 participants