-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom logic to skip configuration of gripper_controllers on Windows or macOS #1471
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
- Coverage 83.83% 83.82% -0.01%
==========================================
Files 122 122
Lines 11120 11121 +1
Branches 944 945 +1
==========================================
Hits 9322 9322
Misses 1489 1489
- Partials 309 310 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I'm glad that it works. Then let's also export all the symbols as other controllers
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sure, thanks for catching this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
gripper_controllers
package was disabled on macOS and Windows as it usedexperimental/optional
, but it does not seems to me that the header is used anymore, and I just tried to compile it on Windows and it compiled fine.Fix #193 .
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)