-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iron to use kimatics interface from Humble #1359
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iron #1359 +/- ##
==========================================
- Coverage 65.09% 65.08% -0.01%
==========================================
Files 107 107
Lines 12184 12184
Branches 7494 7493 -1
==========================================
- Hits 7931 7930 -1
- Misses 1534 1540 +6
+ Partials 2719 2714 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be it is better to branch of from last released version of ros2-master, or we can work on a minor changes to the kinematics_interface that way it works on both Iron and the latest distros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the difference between master and humble of the kinematics interface was, but it seemed to be a lot:
ros-controls/kinematics_interface@humble...master
Whatever you decide, please change this here on the master branch and backport to humble+iron to keep stuff in sync.
fyi: This has to be changed then as well
https://github.com/ros-controls/ros2_control_ci/blob/master/ros_controls.iron.repos
You guys are correct, we should backport the recent changes |
No description provided.