Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron to use kimatics interface from Humble #1359

Closed
wants to merge 1 commit into from
Closed

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Nov 7, 2024

No description provided.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.08%. Comparing base (9b6aa99) to head (13b8018).
Report is 1 commits behind head on iron.

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1359      +/-   ##
==========================================
- Coverage   65.09%   65.08%   -0.01%     
==========================================
  Files         107      107              
  Lines       12184    12184              
  Branches     7494     7493       -1     
==========================================
- Hits         7931     7930       -1     
- Misses       1534     1540       +6     
+ Partials     2719     2714       -5     
Flag Coverage Δ
unittests 65.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@christophfroehlich
Copy link
Contributor

@bmagyar or any chance to backport this #1354?

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it is better to branch of from last released version of ros2-master, or we can work on a minor changes to the kinematics_interface that way it works on both Iron and the latest distros

@christophfroehlich christophfroehlich changed the base branch from iron to master November 7, 2024 09:17
@christophfroehlich christophfroehlich changed the base branch from master to iron November 7, 2024 09:18
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the difference between master and humble of the kinematics interface was, but it seemed to be a lot:
ros-controls/kinematics_interface@humble...master

Whatever you decide, please change this here on the master branch and backport to humble+iron to keep stuff in sync.
fyi: This has to be changed then as well
https://github.com/ros-controls/ros2_control_ci/blob/master/ros_controls.iron.repos

@bmagyar
Copy link
Member Author

bmagyar commented Nov 8, 2024

You guys are correct, we should backport the recent changes

@bmagyar bmagyar closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants