Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch for jazzy #263

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Branch for jazzy #263

merged 4 commits into from
Jan 29, 2025

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jan 29, 2025

we don't want to remove the deprecated code from jazzy #261 #262

@christophfroehlich christophfroehlich added the backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. label Jan 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (803527d) to head (08ee543).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   71.67%   71.67%           
=======================================
  Files           9        9           
  Lines         519      519           
  Branches       85       85           
=======================================
  Hits          372      372           
  Misses         92       92           
  Partials       55       55           
Flag Coverage Δ
unittests 71.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

.github/mergify.yml Outdated Show resolved Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit c061e03 into master Jan 29, 2025
12 checks passed
@christophfroehlich christophfroehlich deleted the branch_jazzy branch January 29, 2025 20:49
mergify bot pushed a commit that referenced this pull request Jan 29, 2025
(cherry picked from commit c061e03)
mergify bot pushed a commit that referenced this pull request Jan 29, 2025
(cherry picked from commit c061e03)
christophfroehlich pushed a commit that referenced this pull request Jan 29, 2025
christophfroehlich pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants