-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch for jazzy #263
Merged
Merged
Branch for jazzy #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
the
backport-jazzy
This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
label
Jan 29, 2025
github-actions
bot
requested review from
destogl,
erickisos,
harderthan,
mcbed,
progtologist,
saikishor and
VX792
January 29, 2025 10:47
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 71.67% 71.67%
=======================================
Files 9 9
Lines 519 519
Branches 85 85
=======================================
Hits 372 372
Misses 92 92
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. |
christophfroehlich
added
the
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
label
Jan 29, 2025
This was referenced Jan 29, 2025
This was referenced Jan 29, 2025
saikishor
requested changes
Jan 29, 2025
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit c061e03)
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit c061e03)
christophfroehlich
pushed a commit
that referenced
this pull request
Jan 29, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
backport-jazzy
This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't want to remove the deprecated code from jazzy #261 #262