-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve has_realtime_kernel method #260
Improve has_realtime_kernel method #260
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 71.67% 70.72% -0.96%
==========================================
Files 9 9
Lines 519 526 +7
Branches 85 87 +2
==========================================
Hits 372 372
- Misses 92 99 +7
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think the approach is OK, but one thought:
Hopefully the kernel uname output will always include this. |
@alexswerner yes! I had to do that to make the Windows CI work. If not, it doesn't compile at all. Maybe, I can fix it differently |
@alexswerner done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
(cherry picked from commit 0534f53)
(cherry picked from commit 0534f53)
(cherry picked from commit 0534f53)
These changes allow the detection of realtime kernel even from the
uname
output. It should be more robust.Fixes: #257