Respect output = "raw"
in oa_fetch()
when result is returned early
#293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
oa_fetch()
, there's a clause to returnres
(the single initial query we do at the start to compute on metadata for stuff like # of pages to expect) early when themeta
field is empty (i.e., simple "direct" queries):openalexR/R/oa_fetch.R
Lines 340 to 347 in 42f4d16
At this point of early return,
res
is always the parsed json, so it was not respectingoutput = "raw"
in cases likeoa_fetch(identifier = "W4396214724", output = "raw")
which triggers that early return.The PR makes it so that this initial
res
can stay either parsed or unparsed, so that it can be returned unparsed if user specifiesoutput = "raw"
. Since we do need the parsed metadata info, that's now tracked inres_meta
. The roundabout way of doing this in the code is to ensure that we only request once and parse as needed.