Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apc information #212

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Add apc information #212

merged 8 commits into from
Oct 24, 2024

Conversation

yjunechoe
Copy link
Collaborator

The apc_list and apc_paid fields in a Work object are now returned as a single data frame in the apc column of the df output

devtools::load_all()
x <- oa_fetch(identifier = c("W1964141474", "W1963991285"))
x$apc
#> [[1]]
#> [1] NA
#> 
#> [[2]]
#>   type value currency value_usd provenance
#> 1 list  4480      USD      4480       doaj
#> 2 paid  4480      USD      4480       doaj

@yjunechoe
Copy link
Collaborator Author

(I'm actually very puzzled by the testthat error I'm getting and can't seem to figure it out - will return to fix at a later time)

@trangdata
Copy link
Collaborator

(I'm actually very puzzled by the testthat error I'm getting and can't seem to figure it out - will return to fix at a later time)

Very strange message indeed! We can always wait a couple days to see if this resolves itself on the OpenAlex's end.

Copy link
Collaborator

@trangdata trangdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to modify some tests but it should be good now.

@trangdata trangdata merged commit 6beed9b into ropensci:main Oct 24, 2024
9 checks passed
@yjunechoe yjunechoe deleted the works-apc branch October 24, 2024 18:57
@yjunechoe
Copy link
Collaborator Author

Thanks for picking this back up for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants