Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking coverage of OA entities #211

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yjunechoe
Copy link
Collaborator

New file openalexR-coverage.R tracks oa2df()'s coverage of OA entity fields (currently just one draft for the Work entity)

New function get_coverage() introduces an interface to the coverage information, given an entity

This could also use some tests to ensure a match between what oa2df() actually returns vs. what we say it returns.

@yjunechoe yjunechoe marked this pull request as draft February 26, 2024 15:57
@yjunechoe
Copy link
Collaborator Author

@trangdata Could you help me double check my understanding of how we process variables from Work objects? And feel free to suggest anything to add to the comments column

@trangdata
Copy link
Collaborator

Thank you for putting this together @yjunechoe 💯 We needed this a long time ago. You're as thorough as always! 🚀

I will make a PR if I think of other things to add to comments.

@rkrug
Copy link

rkrug commented Oct 15, 2024

I like this functionality.

One point: in the case of e.g. biblio, where there are values extracted, it would be great if the field could be specified, e.g. biblio.volume, volume and also biblio, NA to indicate where the value is coming from and that biblio itself is removed.

That would make it clearer to understand and also make it possible to rename sub fields after extraction.

@rkrug
Copy link

rkrug commented Oct 15, 2024

Oh - I would also suggest to add the sorting of the fields in this function (or a separate function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants