Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update oa_query and oa_request examples #203

Merged
merged 1 commit into from
Feb 7, 2024
Merged

update oa_query and oa_request examples #203

merged 1 commit into from
Feb 7, 2024

Conversation

trangdata
Copy link
Collaborator

@trangdata trangdata commented Feb 7, 2024

Closes #202

Copy link
Collaborator

@yjunechoe yjunechoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trangdata trangdata merged commit 52aed87 into main Feb 7, 2024
9 checks passed
@trangdata trangdata deleted the fix-examples branch February 7, 2024 15:49
@yjunechoe
Copy link
Collaborator

yjunechoe commented Feb 7, 2024

Unrelated, but FYI both devtools::check() and urlchecker::url_check() are throwing a warning for the link to the Midjourney website at the end of the readme - it's not a dead link so not sure what the issue is but just noting for future since CRAN can get picky about urls.

✖ Error: README.md:607:40 403: Forbidden
Package hex was made with [Midjourney](https://www.midjourney.com/home/)
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@trangdata
Copy link
Collaborator Author

Thanks @yjunechoe! Where do you see this warning? I ran both functions and am not seeing this error.

@yjunechoe
Copy link
Collaborator

Oh huh maybe this was just me! On second thought, the GHA should also catch this (and all passed) so maybe not an actual issue. I'll see if I can reproduce it when I'm back on my computer (btw that specific output I copied was from url_check())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAlex API request failed [403]
2 participants