Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily test GHA #169

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Daily test GHA #169

merged 5 commits into from
Sep 24, 2023

Conversation

yjunechoe
Copy link
Collaborator

This PR just has ubuntu-latest from R CMD Check run every day.

Since it runs on schedule, it's not attached to commits - rather, they're visible from the Actions tab of the repo. For example, on my fork: https://github.com/yjunechoe/openalexR/actions/workflows/test-daily.yaml

We can also grab a status badge from the same page if we want:

image

In any case if it ever fails I think it should alert us by default but I'm not exactly sure since it hasn't really failed yet 😅

Copy link
Collaborator

@trangdata trangdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, June! 🚀 Thank you for putting this together! I only have one small comment.

# pull_request:
# branches: [main, master]
schedule:
- cron: '0 0 * * *' # daily at midnight UTC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that a tutorial I took suggested doing this some minutes after midnight is ideal since we don't have to fight with other cron jobs scheduled at midnight, but I'm not sure if it's still the case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha that's never crossed my mind but makes sense, why not! I'll change to 00:15

@yjunechoe yjunechoe merged commit 986acbf into ropensci:main Sep 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants