Empty institution lineage #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trangdata
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Thank you for this thorough PR, @yjunechoe! 🚀 Also great work on fixing oa_random as well. I didn't get to look closely at that when the test failed one time.
I don't think we have addressed the NA discussion here, but Oh wait I think you did with empty_inst, so plz feel free to merge when you're ready.
Oops ya that wasn't very clear/intuitive - re-running the reprex on the PR! oa_fetch(identifier = "W1981492994")$author[[1]]$institution_lineage
#> [1] NA "https://openalex.org/I51556381" |
|
Pinging @massimoaria - all checks are passing on main with this PR merged, so I think we have a resubmission version ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #155, this PR ensures that missing author "lineage" information is coded as
NAand applies the same fix forworks2df()toauthors2df().Related: #154 , #156 , #157
Coincidentally, fixing
authors2df()also resolved the last remaining error in tests involvingoa_random(), where the following line was sometimes returning dfs longer than 20 rows because multiple lineages would get unnested longer into duplicate entries of the author inauthors2df().openalexR/tests/testthat/test-oa_fetch.R
Line 291 in ab6554d