Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start on a vcr workflows chapter #94

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

start on a vcr workflows chapter #94

wants to merge 1 commit into from

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Mar 18, 2021

vcr workflow chapter started

Description

Can't do Make task part b/c waiting on some vcr features. Could remove for now.

What other things could we add to vcr workflows?

Related Issue

#9

@sckott sckott requested a review from maelle March 18, 2021 16:42
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think an intro would make sense, what can one expect from this chapter?

@@ -0,0 +1,66 @@
# vcr workflows {#vcr-workflows}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not a vignette with an Rmd fragment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do

There are a number of reasons why you may want to re-record your cassettes:

1. `vcr`/`webmockr` upgrades: you may want to re-record your cassettes if
you've recently upgraded either of these packages. There should in general
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unclear to me whether it's really useful since there should be no problem?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by "there should be no problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a sentence that you wrote in this paragraph, "There should in general be no problem (...)" so I wonder when it is useful.

cassettes have up to date HTTP response bodies from the remote API; helping
you avoid cases where you're essentially testing old API behavior.

## Making sure vcr is working {#vcr-working}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well not vcr but more something like "Making sure your vcr infrastructure is working"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will make that change


How do you know vcr is working without internet access?

- Make sure you have recorded cassettes. Then turn WI-FI off. Now run tests again.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that tip is also earlier in the book because it's an excellent tip you had given me!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good. okay to duplicate here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!


Can my tests run in the absence of my API key?

- After cassettes are recorded, you can temporarily disable your key by replacing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add examples of how you'd do that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@maelle
Copy link
Member

maelle commented Jan 30, 2024

@sckott do you still plan work on this or should we close it?

@sckott
Copy link
Collaborator Author

sckott commented Jan 30, 2024

I think i can finish it, if I don't get it done soon we can close it

@maelle
Copy link
Member

maelle commented Feb 1, 2024

@sckott btw I noticed you didn't have access to the repo any more, so I sent you an invite to grant you admin rights again.

@sckott
Copy link
Collaborator Author

sckott commented Feb 1, 2024

thank you @maelle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants