Don't fail if model doesn't respond to marked for destruction (#88)

rootstrap · Oct 3, 2024 · dc91c8e · dc91c8e
1 parent a403b8a
commit dc91c8e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.reek.yml b/.reek.yml
@@ -23,7 +23,7 @@ detectors:
     allow_calls: []
   FeatureEnvy:
     enabled: true
-    exclude: 
+    exclude:
       - 'YAAF::Form#promote_legacy_errors'
       - 'YAAF::Form#save_models'
   InstanceVariableAssumption:
@@ -44,7 +44,8 @@ detectors:
     max_params: 3
   ManualDispatch:
     enabled: true
-    exclude: []
+    exclude:
+      - 'YAAF::Form#save_models'
   MissingSafeMethod:
     enabled: false
     exclude: []

diff --git a/lib/yaaf/form.rb b/lib/yaaf/form.rb
@@ -53,7 +53,11 @@ def save_models(options)
       options.merge!(validate: false)
 
       models.map do |model|
-        model.marked_for_destruction? ? model.destroy! : model.save!(**options)
+        if model.respond_to?(:marked_for_destruction?) && model.marked_for_destruction?
+          model.destroy!
+        else
+          model.save!(**options)
+        end
       end
     end