External pull request processor job error #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzofab91
approved these changes
Sep 3, 2024
| @@ -79,13 +79,25 @@ def initialize(repository_full_name, pull_request_number) | |||
| end | |||
|
|
|||
| def call | |||
| Builders::ExternalPullRequest.call(pull_request_data) | |||
| Builders::ExternalPullRequest.call(pull_request_data) if pull_request_data | |||
There was a problem hiding this comment.
Suggested change
| Builders::ExternalPullRequest.call(pull_request_data) if pull_request_data | |
| Builders::ExternalPullRequest.call(pull_request_data) if pull_request_data.present? |
| @@ -6,6 +6,7 @@ def initialize(username) | |||
| end | |||
|
|
|||
| def call | |||
| # #byebug | |||
rodrieiz
changed the title
rodrieiz
requested review from
lauperalti,
brunoparma88,
claramaffei and
a team
and removed request for
a team
claramaffei
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pr is to fix this error
This job processes external pull request information for all employees. For this specific user, when fetching all events from their GitHub account, the job encounters a public event that is a pull request linked to a repository that no longer exists—it may have been deleted or something similar. This causes the job to crash because the generated URL is invalid. What I’ve done now is log and notify the failure to process that particular pull request, but ensure that the job continues processing other external pull requests for this user or others.
Resolves #XX