Make api base ready for fullstack #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianPasquale
approved these changes
Nov 23, 2023
enzofab91
approved these changes
Nov 23, 2023
jpascual1994
approved these changes
Nov 23, 2023
PerezIgnacio
approved these changes
Nov 23, 2023
blacksam07
approved these changes
Nov 23, 2023
jeroig
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Remove
api_onlyconfigRevert https://github.com/rootstrap/rails_api_base/pull/253/files. We aren't getting any benefit from it.
Actually, our app is not api only, we still are loading middlewares because they are needed for ActiveAdmin.
2. Add default application layout
Every Rails app comes with one https://github.com/rails/rails/blob/main/railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt
It will be helpful if we ever want to develop an HTML page outside the admin site.
3. Keep application and admin CSS separate
We don't want Arctic Admin styles to leak into application CSS, for that reason, application CSS should go into the
app/assets/stylesheets/application/directory