-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Koin instead of dagger-hilt as DI #49
base: master
Are you sure you want to change the base?
Conversation
Use Koin as dependency inyector
@@ -5,7 +5,7 @@ | |||
<option name="linkedExternalProjectsSettings"> | |||
<GradleProjectSettings> | |||
<option name="delegatedBuild" value="false" /> | |||
<option name="testRunner" value="PLATFORM" /> | |||
<option name="testRunner" value="GRADLE" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to exclude files are already tracked but now are ignored through .gitignore
you can do any of these steps:
git rm --cached <file>
to exclude a filegit rm -r --cached <folder>
to exclude a whole folder
package="com.package"> | ||
|
||
<application android:extractNativeLibs="true" /> | ||
</manifest> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a new line here
// viewModel { BottomBarViewModel(androidApplication()) } | ||
// single { provideIotDao(androidContext()) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of removing these commented lines if they are no longer needed?
Add Koin instead of Hilt as DI as an alternative for this base project
There are some pros and cons about it, at least that I can notice, such as:
PROS
CONS
Here there are some interesting articles which explain the main differences between both:
Dagger-Hilt & Koin under the hood
Koin Vs Dagger-Hilt
PD: I also introduce a test library Mockk, which has very good stuff for testing coroutines, and supports Koin