fix analysisCRS to use network layer, fix OD matrix unique ID data types, and update language to match other QGIS functions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s() for all iso-area algorithms
…riginal data types of the input points and target points
… network algorithms in terms of cost strategy. Update language on maximum cost level.
|
@josephholler thank you very much for the PR! I will review it in detail when I have more time (my calendar is really full right now). I'll keep you posted! :) |
|
@josephholler I just left some comments at the referenced issues - lets discuss the changes there before returning to an in-depth review of the PR. |
|
@josephholler I am a little confused. Did you move the changes of this PR also to PR #37 ? If all changes of this PR are present in #37 , could you please close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates language in graphic interface and some field names in response to issue #32
Fixes issue #31 to allow for different data types in the OD Matrix unique ID's.
May fix issue #29 by always using the network layer's CRS for analysis.
Clarifies some of the ambiguity of units mentioned in issue #17 , but so far this pull request is focused on the input units for Iso-Areas. More work is needed to clarify output units of time and distance and input units for speed, especially if the CRS uses linear units other than meters.