Latest changes for SAW integration #333
Conversation
Return result instead of nil
| end | ||
|
|
||
| def check_out | ||
| (today + 31 * one_day).strftime("%d/%m/%Y") | ||
| (today + 92 * one_day).strftime("%d/%m/%Y") |
There was a problem hiding this comment.
Sorry my ignorance, but previously we were quoting the price for 1 day (30 days from now to 31 days from now), and now we are quoting the price for 2 days (90 to 92 days from now). Won't that cause the returned price to account for 2 nights?
What am I missing here?
There was a problem hiding this comment.
YES 💥 Looks like I didn't changed the second part which uses these prices 💭 💭
Moreover, now I don't like what my PropertyRate mapper / entity do, I need to refactor them & fix this bug.
@keang please hold on with the merge
Bugfix/saw price fetching
|
@sharipov-ru all fixes in for this PR? |
|
@keang YES! |
|
I understand this PR would possibly reduce, but not solve the error from #287 and #289. |
|
@keang absolutely right! |
This PR includes most probable changes for SAW supplier (also some not significant changes).
PR will not be merged until all SAW questions/sync strategy will not be answered and resolved.
WIP