-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properties with 0.0 rate #289
Comments
Maybe this happens because the property was not available (marked as "on-request") at this time. |
Before starting discussion on this topic, let me first remind the overall strategy for setting prices for SAW properties / units. Firstly, metadata worker performs SAW Search API calls, and the response includes However, sometimes price is returned as Some numbers: Staging:
It's important to mention that 329 properties from 368 are on request, so sometimes they return prices by Search API endpoint even when property is on request, which is positive news for us since we would be able to import more properties to our system with existing estimations. Production environment is a bit different in numbers:
So positive news here is the fact that almost all properties have this price value set and only 11 properties from 334 haven't. We just haven't these numbers before because we ignored those properties which are Next. Let's talk about rates for property units because To fetch rates for units we currently perform bulk rates search API call with 20 ids on every request. This endpoint return prices only for units which currently are not on the request and very often this endpoint doesn't return rates for units in property because most of the property units are on request. Currently, when we fail to fetch specific rates for property units, the very first price from property is used for every unit in this property. which means that for most properties we would have one price for all units inside property and the exact price will be fetched only while quoting price. So that, continuing what @rmascarenhas suggested in the first post:
I can admit that 11 properties from 334 on production have no any price estimation and it's not currently issue on the mapper side. And answering @leandrocg's question:
Unfortunately, I failed to find any dates when those properties available and return prices. This ids are: [2957, 2540, 2825, 2823, 2824, 2941, 2960, 2974, 2976, 2970, 2763] I suggest to ignore these ids (maybe hardcode it all) and move on without those properties for the beginning. |
Rollbar issue: |
Description
When publishing a property, we need to set the initial nightly/weekly/monthly for it. However, for some properties such values are set to
0.0
, causing Roomorama to reject the property.Possible solutions
We need to double check our mapper to make sure it's correctly mapping the data. It could be an issue on our mapper, or on their data, but we need more investigation.
Occurrences
#304683, #303098
The text was updated successfully, but these errors were encountered: