Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIALOG_TITLE argument is without effect on Marshmallow #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtotschnig
Copy link

Problem:

If you try to set a dialog title for a Caldroid dialog with

    CaldroidFragment f = new CaldroidFragment();
    Bundle args = new Bundle();
    args.putString(DIALOG_TITLE, "My dialog title");
    f.setArguments(args);

the title is not shown on Marshmallow devices.

Reason

The default for windowNoTitle is false for Lollipop and below, but true on Marshmallow. Compare with http://stackoverflow.com/a/32711916/1199911

Solution

Set windowNotTitle explicitly to false.

…need to set it otherwise DIALOG_TITLE argument does not work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant