[rooch-portal] Fix client error: Add null checks and input validation #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@wow-sven @jojoo-eth Please help review. |
wow-sven
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With or without connect wallet, Nullish Checks and Input Validation are not handled for key values resulting in constant error messages from the client, and Handling Invalid Inputs is not handled when extractCoinInfoContent is retrieved resulting in incorrect requests and incorrect return values.
Fix:
Add Nullish Checks to all relevant values and Input Validation and Handling Invalid Inputs to methods to enhance code fault tolerance, reduce user-client anomalies, and reduce invalid requests sent.