v3.7.3

.github/ISSUE_TEMPLATE/bug_report.md

@@ -2,7 +2,6 @@
 name: Bug report
 about: Report a bug, issue or problem
 title: "[Bug] Bug title"
-labels: bug
 assignees: ""
 ---
 

.github/ISSUE_TEMPLATE/custom.md

@@ -2,6 +2,5 @@
 name: Custom issue template
 about: Describe this issue template's purpose here.
 title: "[Other] Custom issue title"
-labels: other
 assignees: ""
 ---

.github/ISSUE_TEMPLATE/feature_request.md

@@ -2,7 +2,6 @@
 name: Feature request
 about: Suggest an idea for this project
 title: "[Feature] Feature title"
-labels: feature
 assignees: ""
 ---
 

.github/dependabot.yml

@@ -0,0 +1,16 @@
+version: 2
+updates:
+  - package-ecosystem: "npm"
+    directory: "/frontend"
+    schedule:
+      interval: "weekly"
+    reviewers:
+      - "gantoine"
+    target-branch: "master"
+  - package-ecosystem: "pip"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    reviewers:
+      - "adamantike"
+    target-branch: "master"

.github/workflows/pytest.yml

@@ -50,7 +50,7 @@ jobs:
 
       - name: Install dependencies
         run: |
-          poetry install --sync
+          poetry sync --extras test
 
       - name: Initiate database
         run: |

DEVELOPER_SETUP.md

@@ -45,14 +45,14 @@ Then create the virtual environment
 ```sh
 # Fix disable parallel installation stuck: $> poetry config experimental.new-installer false
 # Fix Loading macOS/linux stuck: $> export PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring
-poetry install --sync
+poetry sync
 ```
 
 If you are on Arch Linux or another Arch-based distro, you need to run the command as follows:
 
 ```sh
 # https://bbs.archlinux.org/viewtopic.php?id=296542
-CFLAGS="-Wno-error=incompatible-pointer-types" poetry install --sync
+CFLAGS="-Wno-error=incompatible-pointer-types" poetry sync
 ```
 
 #### - Spin up mariadb in docker

backend/alembic/versions/0009_models_refactor.py

@@ -9,7 +9,7 @@
 import sqlalchemy as sa
 from alembic import op
 from sqlalchemy.exc import OperationalError
-from utils.database import CustomJSON
+from utils.database import CustomJSON, is_postgresql
 
 # revision identifiers, used by Alembic.
 revision = "0009_models_refactor"
@@ -21,6 +21,10 @@
 def upgrade() -> None:
     connection = op.get_bind()
 
+    json_array_build_func = (
+        "jsonb_build_array()" if is_postgresql(connection) else "JSON_ARRAY()"
+    )
+
     try:
         with op.batch_alter_table("platforms", schema=None) as batch_op:
             batch_op.alter_column(
@@ -87,13 +91,13 @@ def upgrade() -> None:
             "url_screenshots",
             existing_type=CustomJSON(),
             nullable=True,
-            existing_server_default=sa.text("(JSON_ARRAY())"),
+            existing_server_default=sa.text(f"({json_array_build_func})"),
         )
         batch_op.alter_column(
             "path_screenshots",
             existing_type=CustomJSON(),
             nullable=True,
-            existing_server_default=sa.text("(JSON_ARRAY())"),
+            existing_server_default=sa.text(f"({json_array_build_func})"),
         )
 
     try:
@@ -108,6 +112,10 @@ def upgrade() -> None:
 def downgrade() -> None:
     connection = op.get_bind()
 
+    json_array_build_func = (
+        "jsonb_build_array()" if is_postgresql(connection) else "JSON_ARRAY()"
+    )
+
     with op.batch_alter_table("roms", schema=None) as batch_op:
         batch_op.alter_column(
             "igdb_id",
@@ -136,13 +144,13 @@ def downgrade() -> None:
             "path_screenshots",
             existing_type=CustomJSON(),
             nullable=False,
-            existing_server_default=sa.text("(JSON_ARRAY())"),
+            existing_server_default=sa.text(f"({json_array_build_func})"),
         )
         batch_op.alter_column(
             "url_screenshots",
             existing_type=CustomJSON(),
             nullable=False,
-            existing_server_default=sa.text("(JSON_ARRAY())"),
+            existing_server_default=sa.text(f"({json_array_build_func})"),
         )
         batch_op.alter_column(
             "file_size_units", existing_type=sa.VARCHAR(length=10), nullable=True

backend/alembic/versions/0012_add_regions_languages.py

@@ -18,19 +18,22 @@
 
 
 def upgrade() -> None:
-    # ### commands auto generated by Alembic - please adjust! ###
+    connection = op.get_bind()
+
     with op.batch_alter_table("roms", schema=None) as batch_op:
         batch_op.add_column(sa.Column("regions", CustomJSON(), nullable=True))
         batch_op.add_column(sa.Column("languages", CustomJSON(), nullable=True))
 
     with op.batch_alter_table("roms", schema=None) as batch_op:
         # Set default values for languages and regions
-        batch_op.execute("UPDATE roms SET languages = JSON_ARRAY()")
-        batch_op.execute("UPDATE roms SET regions = JSON_ARRAY(region)")
+        if is_postgresql(connection):
+            batch_op.execute("UPDATE roms SET languages = jsonb_build_array()")
+            batch_op.execute("UPDATE roms SET regions = jsonb_build_array(region)")
+        else:
+            batch_op.execute("UPDATE roms SET languages = JSON_ARRAY()")
+            batch_op.execute("UPDATE roms SET regions = JSON_ARRAY(region)")
         batch_op.drop_column("region")
 
-    # ### end Alembic commands ###
-
 
 def downgrade() -> None:
     connection = op.get_bind()

backend/alembic/versions/0014_asset_files.py

@@ -191,7 +191,10 @@ def upgrade() -> None:
 
     # Move data around
     with op.batch_alter_table("roms", schema=None) as batch_op:
-        batch_op.execute("update roms set igdb_metadata = JSON_OBJECT()")
+        if is_postgresql(connection):
+            batch_op.execute("update roms set igdb_metadata = jsonb_build_object()")
+        else:
+            batch_op.execute("update roms set igdb_metadata = JSON_OBJECT()")
         batch_op.execute(
             "update roms set path_cover_s = '', path_cover_l = '', url_cover = '' where url_cover = 'https://images.igdb.com/igdb/image/upload/t_cover_big/nocover.png'"
         )

backend/alembic/versions/0015_mobygames_data.py

@@ -8,7 +8,7 @@
 
 import sqlalchemy as sa
 from alembic import op
-from utils.database import CustomJSON
+from utils.database import CustomJSON, is_postgresql
 
 # revision identifiers, used by Alembic.
 revision = "0015_mobygames_data"
@@ -18,7 +18,8 @@
 
 
 def upgrade() -> None:
-    # ### commands auto generated by Alembic - please adjust! ###
+    connection = op.get_bind()
+
     with op.batch_alter_table("platforms", schema=None) as batch_op:
         batch_op.add_column(sa.Column("moby_id", sa.Integer(), nullable=True))
 
@@ -27,9 +28,10 @@ def upgrade() -> None:
         batch_op.add_column(sa.Column("moby_metadata", CustomJSON(), nullable=True))
 
     with op.batch_alter_table("roms", schema=None) as batch_op:
-        batch_op.execute("update roms set moby_metadata = JSON_OBJECT()")
-
-    # ### end Alembic commands ###
+        if is_postgresql(connection):
+            batch_op.execute("update roms set moby_metadata = jsonb_build_object()")
+        else:
+            batch_op.execute("update roms set moby_metadata = JSON_OBJECT()")
 
 
 def downgrade() -> None:

backend/alembic/versions/0030_user_email_null.py

@@ -0,0 +1,25 @@
+"""Change empty string in users.email to NULL.
+
+Revision ID: 951473b0c581
+Revises: 0029_platforms_custom_name
+Create Date: 2025-01-14 01:30:39.696257
+
+"""
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = "0030_user_email_null"
+down_revision = "0029_platforms_custom_name"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    with op.batch_alter_table("users", schema=None) as batch_op:
+        batch_op.execute("UPDATE users SET email = NULL WHERE email = ''")
+
+
+def downgrade() -> None:
+    with op.batch_alter_table("users", schema=None) as batch_op:
+        batch_op.execute("UPDATE users SET email = '' WHERE email IS NULL")