Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move mapper logic into rom-mapper #387

Conversation

GustavoCaso
Copy link
Member

@GustavoCaso GustavoCaso commented Mar 9, 2017

#349
@solnic
As we talked about this an early WIP for extracting the logic of Mappers to rom-mapper and register via plugin, rom-rb/rom-mapper#42.

I haven't actually tested myself but I wanted to have a place where we could discuss further actions.

Following how the plugin system work I hope I have it understand it, I remove all the code related to Mappers to is PluginConfiguration.

This is PR in rom-mapper adding the behavior for register mapper

@solnic
Copy link
Member

solnic commented May 2, 2017

So, the PR on rom-mapper side looks good, so last thing to do is to update things here so the build can pass :)

@GustavoCaso GustavoCaso force-pushed the extract_mapper_loggic_to_rom_mapper branch from 143fee9 to f664213 Compare May 29, 2017 06:59
@GustavoCaso GustavoCaso deleted the extract_mapper_loggic_to_rom_mapper branch May 29, 2017 21:50
@GustavoCaso GustavoCaso restored the extract_mapper_loggic_to_rom_mapper branch May 29, 2017 21:51
@GustavoCaso GustavoCaso deleted the extract_mapper_loggic_to_rom_mapper branch May 29, 2017 21:51
@GustavoCaso GustavoCaso restored the extract_mapper_loggic_to_rom_mapper branch May 29, 2017 21:51
@GustavoCaso GustavoCaso deleted the extract_mapper_loggic_to_rom_mapper branch May 29, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants