[WIP] Move mapper logic into rom-mapper #387
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#349
@solnic
As we talked about this an early WIP for extracting the logic of
Mappers
torom-mapper
and register via plugin, rom-rb/rom-mapper#42.I haven't actually tested myself but I wanted to have a place where we could discuss further actions.
Following how the plugin system work I hope I have it understand it, I remove all the code related to Mappers to is PluginConfiguration.
This is PR in
rom-mapper
adding the behavior for register mapper