Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed inconsistency in requirements #1693

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Removed inconsistency in requirements #1693

merged 1 commit into from
Aug 23, 2024

Conversation

kravaring
Copy link
Collaborator

Title of Pull Request

🤔 This is a ...

  • 🌟 New task
  • 🌐 New module
  • ⚙️ Update to an existing task
  • 🔧 Update to an existing module
  • 🔗 Update or addition of external resources or links
  • 🐛 Fix in a task or related content
  • 🛠 Fix in a module or related content
  • ✏️ Fixed a typo or grammatical error
  • 🔗 Fixed a broken link
  • ❓ Other (specify: ****____****)

Description

  • Brief Overview:
  • Implementation Approach:

Additional Information

  • Screenshots/Links:
  • Related Issues:

Checklist

  • ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

@kravaring kravaring requested a review from SpaNb4 as a code owner August 22, 2024 20:07
@github-actions github-actions bot added the react label Aug 22, 2024
ParfenenkovEdit
ParfenenkovEdit approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@ParfenenkovEdit ParfenenkovEdit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@kravaring kravaring merged commit 30ba865 into master Aug 23, 2024
1 check passed
@kravaring kravaring deleted the fix/react2024q3-final-01 branch August 23, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Margaryta-Maletz Margaryta-Maletz Margaryta-Maletz approved these changes

@ParfenenkovEdit ParfenenkovEdit ParfenenkovEdit approved these changes

@andron13 andron13 Awaiting requested review from andron13

@SpaNb4 SpaNb4 Awaiting requested review from SpaNb4 SpaNb4 is a code owner

Assignees

@kravaring kravaring

Labels
react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kravaring @ParfenenkovEdit @Margaryta-Maletz