Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix interactivity, exclude :active in coffee-house-week1.md #1355

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

letohx
Copy link
Contributor

@letohx letohx commented Nov 20, 2023

Title of Pull Request

🤔 This is a ...

  • 🐛 Fix in a task or related content

Description

  • Brief Overview:

    • This pull request addresses a misunderstanding regarding the use of the :active pseudo-class in the task. Since the task creators did not plan for the use of the :active pseudo-class, the requirement for a mandatory smooth state transition on click has been removed to align with the original task intent.
  • Implementation Approach:

    • Modified the task conditions to eliminate the requirement for a mandatory smooth state transition on click.
    • Ensured clarity by removing potential confusion caused by the unintended inclusion of the :active pseudo-class.

Additional Information

image

Checklist

  • ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

@WiiJoy WiiJoy merged commit 9ec36fd into rolling-scopes-school:master Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants