Skip to content

Commit

Permalink
Revert "chore: skip a test due to bug in rolldown"
Browse files Browse the repository at this point in the history
This reverts commit 15a9fda.
  • Loading branch information
sapphi-red committed Jan 23, 2025
1 parent 0c18347 commit 9da0120
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
3 changes: 1 addition & 2 deletions playground/resolve/__tests__/resolve.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,7 @@ test('resolve.conditions', async () => {
expect(await page.textContent('.custom-condition')).toMatch('[success]')
})

// NOTE: skip for now due to https://github.com/rolldown/rolldown/issues/3364
test.skip('resolve package that contains # in path', async () => {
test('resolve package that contains # in path', async () => {
expect(await page.textContent('.path-contains-sharp-symbol')).toMatch(
'[success] true #',
)
Expand Down
9 changes: 4 additions & 5 deletions playground/resolve/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -397,11 +397,10 @@ <h2>utf8-bom-package</h2>
import contains from 'es5-ext/string/#/contains'
import { last } from '@vitejs/test-resolve-sharp-dir'

// NOTE: skip for now due to https://github.com/rolldown/rolldown/issues/3364
// text(
// '.path-contains-sharp-symbol',
// `[success] ${contains.call('#', '#')} ${last.call('#')}`,
// )
text(
'.path-contains-sharp-symbol',
`[success] ${contains.call('#', '#')} ${last.call('#')}`,
)

import nonNormalizedAbsolute from '@non-normalized'
text('.non-normalized', nonNormalizedAbsolute)
Expand Down

0 comments on commit 9da0120

Please sign in to comment.