Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): module generation + fix BUF cache permission issue #239

Merged
merged 12 commits into from
Oct 12, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Oct 12, 2024

Summary

Recently the patch #238 was pushed which I believe will fix module generation issues I was having before. I figured it was github runner issues, but may have been the Ubuntu 22.04 bug found and reported by other users (due to file system permissions). This re-attempts the module generation I started in #172

@Reecepbcups
Copy link
Member Author

Reecepbcups commented Oct 12, 2024

WOOOO it works and solves the other buf issue for Ubuntu. need to patch docs as well & test with macos + wsl

@Reecepbcups Reecepbcups changed the title test(e2e): module generation test(e2e): module generation + fix BUF cache permission issue Oct 12, 2024
@Reecepbcups
Copy link
Member Author

Reecepbcups commented Oct 12, 2024

confirmed to work with mac os m3 & WSL

@Reecepbcups Reecepbcups marked this pull request as ready for review October 12, 2024 20:17
@Reecepbcups Reecepbcups merged commit a10b085 into release/v0.50 Oct 12, 2024
13 checks passed
@Reecepbcups Reecepbcups deleted the reece/extra-module-validation-part-2 branch October 12, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant