Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore build for pyramid and cli entrypoints #471

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Restore build for pyramid and cli entrypoints #471

merged 3 commits into from
Jan 21, 2025

Conversation

brianr
Copy link
Member

@brianr brianr commented Jan 21, 2025

Description of the change

The build for the entrypoints for pyramid and the rollbar cli were removed in the move from setup.py to pyproject.toml in #455 . This PR adds them to pyproject.toml.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

n/a

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@brianr brianr requested a review from danielmorell January 21, 2025 06:24
danielmorell
danielmorell approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing that!

@danielmorell danielmorell merged commit 3aca977 into master Jan 21, 2025
89 checks passed
@danielmorell danielmorell deleted the brianr/restore-cli-and-pyramid branch January 21, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmorell danielmorell danielmorell approved these changes

@matux matux matux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianr @matux @danielmorell