Add support for the Roblox Open Cloud API #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AssetCreator for RobloxSyncBackend.upload_to_group_id + rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1 by adding support for the Open Cloud API to Tarmac.
It adds a new global option:
--api-key. If not specified in a command, Tarmac will attempt to read it from the environment variableTARMAC_API_KEY. When this option is present, Tarmac will use Open Cloud. Otherwise, it will fall back to the legacy API.It adds a new field to the project format:
upload-to-user-id. This field (orupload-to-group-id) is required when using Open Cloud, and is mutually exclusive withupload-to-group-id. If the user provides both, or neither are present when using Open Cloud, Tarmac will raise an error.Lastly, it adds two new options to the
upload-imagecommand:user-idandgroup-id. Likewise, one of these is required to use the Open Cloud API, and they are mutually exclusive.Because there's no way to download assets using Open Cloud yet, the implementation here always falls back to the legacy API to download assets. This functionality is broken right now anyway (the endpoint is returning a 404 page), but fixing it is not relevant for this PR!