View rich diffs for Source property changes #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-diff-viewer
…partially match background color
…ng-diff-viewer
…ng-diff-viewer
…ng-diff-viewer
…diff to apply anything
boatbomber
added
type: enhancement
boatbomber
added
size: medium
impact: medium
Dekkonot
requested changes
Jul 27, 2023
Co-authored-by: Micah <[email protected]>
Dekkonot
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property inspection on .Source changes is just not helpful in the current state:
To remedy this, I've implemented Neil Fraser's diffing in Luau and used it to create meaningful Source diff pop-out widgets. It uses my open source Highlighter module to apply syntax highlighting that matches the user's Studio preferences.