Don't bail on attempt to reflect unknown serialized data types #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
approved these changes
Nov 1, 2024
kennethloeffler
deleted the
rbx-reflector-dont-bail-on-unknown-serialized-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
rbx_reflector generatebails immediately upon encountering a unknown serialized data type. This lets us know when we might need to implement a new data type, but it's kind of annoying to know only that there's a least one property that has the data type, and for the command to fail completely instead of generating a database.This PR makes
rbx_reflector generateprint a warning and continue when encountering unknown serialized data types, rather than bailing. This allows the operator to see all of the properties, instead of just one, and will also actually generate the database.