Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform property migrations in rbx_binary serializer #339

Merged

Commits on Aug 3, 2023

  1. Add test

    Contains both migrated and migrated-to properties
    kennethloeffler committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9836bcd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50668eb View commit details
    Browse the repository at this point in the history
  3. Update PropInfo.migration when revisiting an existing PropInfo

    This is necessary because if collect_type_info processes a
    migrated-to property first, and then processes a migrated property
    later, PropInfo.migration will still be None and we won't be able to
    apply migrations
    
    This would not work if a logical property had multiple, different
    migration operations associated with it, but thankfully that is not
    the case!
    kennethloeffler committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    294d48f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8797135 View commit details
    Browse the repository at this point in the history
  5. Perform migrations in serialize_properties

    This is kind of ugly...
    
    Because migrated and migrated-to properties can both exist in the same
    DOM, we're won't necessarily get a consistent variant type here, so we just ignore
    any migration failures and assume values that fail are already the
    correct type
    kennethloeffler committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    31e6bbf View commit details
    Browse the repository at this point in the history
  6. Add test snapshot

    Woo, lookin good!
    kennethloeffler committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6688e6c View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Configuration menu
    Copy the full SHA
    5c9996e View commit details
    Browse the repository at this point in the history