Skip to content

Commit

Permalink
Don't serialize ScriptGuid, UniqueId, and HistoryId (#327)
Browse files Browse the repository at this point in the history
Closes #314 and resolves #324 for now.

I've decided that `LuaSourceContainer.ScriptGuid`, `Instance.UniqueId`,
and `Instance.HistoryId` shouldn't serialize for the time being. All
they do is make diff noise and they aren't especially useful for Rojo or
Lune users at this time.

In the process, I discovered that `rbx_reflector` actually wasn't
catching `UniqueId` properties so I've corrected that. I'll add it to my
list of things to check in new data type implementations going forward.
  • Loading branch information
Dekkonot authored Jul 26, 2023
1 parent 620d991 commit 5db11f8
Show file tree
Hide file tree
Showing 12 changed files with 112 additions and 995 deletions.
11 changes: 11 additions & 0 deletions patches/instance.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
Change:
Instance:
# UniqueId properties might be random everytime Studio saves a place file
# and don't have a use right now outside of packages, which Rojo doesn't
# account for anyway. They generate diff noise, so we shouldn't serialize
# them until we have to.
UniqueId:
Serialization:
Type: DoesNotSerialize
HistoryId:
Serialization:
Type: DoesNotSerialize

archivable:
AliasFor: Archivable
Archivable:
Expand Down
7 changes: 7 additions & 0 deletions patches/lua-source-container.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Change:
LuaSourceContainer:
# ScriptGuid is randomly generated everytime a script is saved from Studio
# and it makes no sense for us to write it ourselves at this moment.
ScriptGuid:
Serialization:
Type: DoesNotSerialize
Loading

0 comments on commit 5db11f8

Please sign in to comment.