Add events count and export metrics #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved unused fmt import from config/config.go
itisallgood
requested review from
Avi-Robusta,
arikalon1 and
RoiGlinik
and removed request for
RoiGlinik
arikalon1
approved these changes
Sep 18, 2024
pkg/client/run.go
Outdated
| @@ -35,6 +39,15 @@ import ( | |||
|
|
|||
| // Run runs the event loop processing with given handler | |||
| func Run(conf *config.Config) { | |||
| metricsPort := ":2112" | |||
There was a problem hiding this comment.
I think a better name for this would be listenAddress or something
I think the format is "host:port"
Would it be better allowing to override it with an environment variable?
There was a problem hiding this comment.
Yes, sure. I will add environment variable for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests performed