-
Notifications
You must be signed in to change notification settings - Fork 60
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: improve logging and add optional perf logging
- Loading branch information
Showing
9 changed files
with
144 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import time | ||
import logging | ||
|
||
from functools import wraps | ||
|
||
from holmes.common.env_vars import ( | ||
LOG_PERFORMANCE, | ||
) | ||
|
||
class PerformanceTiming: | ||
def __init__(self, name): | ||
if not LOG_PERFORMANCE: | ||
return | ||
self.ended = False | ||
|
||
self.name = name | ||
self.start_time = time.time() | ||
self.last_measure_time = self.start_time | ||
self.last_measure_label = "Start" | ||
self.timings = [] | ||
|
||
def measure(self, label): | ||
if not LOG_PERFORMANCE: | ||
return | ||
if self.ended: | ||
raise Exception("cannot measure a perf timing that is already ended") | ||
current_time = time.time() | ||
|
||
time_since_start = int((current_time - self.start_time) * 1000) | ||
time_since_last = int((current_time - self.last_measure_time) * 1000) | ||
|
||
self.timings.append((label, time_since_last, time_since_start)) | ||
|
||
self.last_measure_time = current_time | ||
self.last_measure_label = label | ||
|
||
def end(self): | ||
if not LOG_PERFORMANCE: | ||
return | ||
self.ended = True | ||
current_time = time.time() | ||
time_since_start = int((current_time - self.start_time) * 1000) | ||
message = f'{self.name}(TOTAL) {time_since_start}ms' | ||
logging.info(message) | ||
for label, time_since_last, time_since_start in self.timings: | ||
logging.info(f'\t{self.name}({label}) +{time_since_last}ms {time_since_start}ms') | ||
|
||
def log_function_timing(func): | ||
@wraps(func) | ||
def function_timing_wrapper(*args, **kwargs): | ||
start_time = time.perf_counter() | ||
result = func(*args, **kwargs) | ||
end_time = time.perf_counter() | ||
total_time = int((end_time - start_time) * 1000) | ||
logging.info(f'Function "{func.__name__}()" took {total_time}ms') | ||
return result | ||
return function_timing_wrapper |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.