Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superadmins #39

Merged
merged 22 commits into from
Sep 11, 2024
Merged

Superadmins #39

merged 22 commits into from
Sep 11, 2024

Conversation

PizieDust
Copy link
Collaborator

This PR implements super-users and includes an admin middleware.
To be included is the UI to make other users admins.

@PizieDust PizieDust added the enhancement New feature or request label Sep 6, 2024
@PizieDust PizieDust requested a review from hannesm September 6, 2024 05:11
@PizieDust PizieDust self-assigned this Sep 6, 2024
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Show resolved Hide resolved
users_index.ml Show resolved Hide resolved
@hannesm
Copy link
Contributor

hannesm commented Sep 6, 2024

I pushed a commit to this PR to use mirage < 4.7.0 and albatross < 2.2.0. let's make the upgrade to the next version of mirage & albatross in a separate PR.

@PizieDust PizieDust requested a review from hannesm September 7, 2024 07:25
@hannesm
Copy link
Contributor

hannesm commented Sep 7, 2024

that's fine to merge, or do you plan to include the UI (toggle admin status) in this PR?

unikernel.ml Outdated Show resolved Hide resolved
@PizieDust
Copy link
Collaborator Author

that's fine to merge, or do you plan to include the UI (toggle admin status) in this PR?

I have the base UI ready. Now just need to add the admin toggle functionality.
It's almost the same code as the activation toggle

@PizieDust PizieDust requested a review from hannesm September 9, 2024 08:34
@PizieDust
Copy link
Collaborator Author

PizieDust commented Sep 9, 2024

that's fine to merge, or do you plan to include the UI (toggle admin status) in this PR?

I have the base UI ready. Now just need to add the admin toggle functionality. It's almost the same code as the activation toggle

@hannesm I think we can merge now :)

unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
@hannesm hannesm merged commit 35db1c6 into main Sep 11, 2024
2 checks passed
@hannesm hannesm deleted the superadmin branch September 11, 2024 10:39
@hannesm
Copy link
Contributor

hannesm commented Sep 11, 2024

thanks a lot, merged. sorry for the delay.

@hannesm hannesm mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants