Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page #22

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Landing page #22

merged 8 commits into from
Aug 26, 2024

Conversation

PizieDust
Copy link
Collaborator

Make the landing page a little more organized and some minor fixes.

@PizieDust PizieDust added the enhancement New feature or request label Aug 23, 2024
@PizieDust PizieDust requested a review from hannesm August 23, 2024 23:15
@PizieDust PizieDust self-assigned this Aug 23, 2024
@hannesm
Copy link
Contributor

hannesm commented Aug 26, 2024

this looks fine to me, the only question I have whether we can scale down the images (> 1MB and 500kB is quite a lot). WDYT?

@hannesm
Copy link
Contributor

hannesm commented Aug 26, 2024

I downsized the images. thanks a lot.

@hannesm hannesm merged commit 681aad4 into main Aug 26, 2024
1 of 2 checks passed
@hannesm hannesm deleted the landing_page branch August 26, 2024 08:01
@reynir
Copy link
Contributor

reynir commented Aug 26, 2024

In assets/albatross_1.png albatross is misspelt twice in different ways, and in assets/mirage_os_1.png mirage is also misspelt just FYI.

@hannesm
Copy link
Contributor

hannesm commented Aug 26, 2024

thanks @reynir -- @PizieDust any chance you can modify the original images to fix the typos? I used (from ImageMagick) convert <file> -resize <current-pixels / 5> <file>.2, followed by mv <file>.2 <file> for downscaling -- now the pixels are ~200x200, which looks sufficient.

@hannesm
Copy link
Contributor

hannesm commented Aug 26, 2024

I squash-merged so that git doesn't retain the big files in the repository.

@PizieDust
Copy link
Collaborator Author

PizieDust commented Aug 26, 2024

@reynir thanks for the catch. I can correct the typos. I'll download your compressed version so it maintains the new sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants