Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates #21

Merged
merged 9 commits into from
Aug 21, 2024
Merged

UI updates #21

merged 9 commits into from
Aug 21, 2024

Conversation

PizieDust
Copy link
Collaborator

@PizieDust PizieDust commented Aug 21, 2024

This PR does the following.

  • Separates the layout into authenticated and guest layouts.
  • Displays error messages in a dedicated UI (different for both authenticated users and guest users.
  • A single module to manage responses.
  • A page for user management (on the dashboard sidebar menu Users)
  • Adds cookie authentication to the configurations endpoint. (Login and Register I believe don't require the user to already be authenticated so these are open).

@PizieDust PizieDust added the enhancement New feature or request label Aug 21, 2024
@PizieDust PizieDust requested a review from hannesm August 21, 2024 06:04
@PizieDust PizieDust self-assigned this Aug 21, 2024
@hannesm
Copy link
Contributor

hannesm commented Aug 21, 2024

This looks nice. Just for my understanding:

  • when /api/YYY is requested and an error occurs, a json error is being sent back
  • when another page is requested and an error occurs, the error page is displayed

both use the HTTP reply code that is the error code as well!?

@hannesm hannesm merged commit 5f0642b into main Aug 21, 2024
2 checks passed
@hannesm hannesm deleted the ui-updates branch August 21, 2024 08:26
@hannesm
Copy link
Contributor

hannesm commented Aug 21, 2024

thanks a lot!

@PizieDust
Copy link
Collaborator Author

This looks nice. Just for my understanding:

  • when /api/YYY is requested and an error occurs, a json error is being sent back
  • when another page is requested and an error occurs, the error page is displayed

both use the HTTP reply code that is the error code as well!?

Yes exactly. This is the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants