Update unikernel with new build from builds.robur.coop #105
+507
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reynir
requested changes
Jan 30, 2025
reynir
approved these changes
Jan 31, 2025
Comment on lines
+122
to
+174
| match | ||
| (req_only_bridges, mft_only_bridges, req_only_blocks, mft_only_blocks) | ||
| with | ||
| | [], [], [], [] -> Ok () | ||
| | req_only_bridges, [], [], [] -> | ||
| Error | ||
| (`Msg | ||
| ("Network devices missing from manifest: " | ||
| ^ String.concat "," req_only_bridges)) | ||
| | [], mft_only_bridges, [], [] -> | ||
| Error | ||
| (`Msg | ||
| ("Network devices only in manifest: " | ||
| ^ String.concat "," mft_only_bridges)) | ||
| | [], [], req_only_blocks, [] -> | ||
| Error | ||
| (`Msg | ||
| ("Block devices missing from manifest: " | ||
| ^ String.concat "," req_only_blocks)) | ||
| | [], [], [], mft_only_blocks -> | ||
| Error | ||
| (`Msg | ||
| ("Block devices only in manifest: " | ||
| ^ String.concat "," mft_only_blocks)) | ||
| | req_only_bridges, req_only_blocks, [], [] -> | ||
| Error | ||
| (`Msg | ||
| ("Network devices missing from manifest: " | ||
| ^ String.concat "," req_only_bridges | ||
| ^ " and block devices missing from manifest: " | ||
| ^ String.concat "," req_only_blocks)) | ||
| | [], req_only_blocks, mft_only_bridges, [] -> | ||
| Error | ||
| (`Msg | ||
| ("Network devices only in manifest: " | ||
| ^ String.concat "," mft_only_bridges | ||
| ^ " and block devices missing from manifest: " | ||
| ^ String.concat "," req_only_blocks)) | ||
| | [], [], mft_only_blocks, req_only_bridges -> | ||
| Error | ||
| (`Msg | ||
| ("Network devices missing from manifest: " | ||
| ^ String.concat "," req_only_bridges | ||
| ^ " and block devices only in manifest: " | ||
| ^ String.concat "," mft_only_blocks)) | ||
| | req_only_bridges, [], mft_only_blocks, [] -> | ||
| Error | ||
| (`Msg | ||
| ("Network devices missing from manifest: " | ||
| ^ String.concat "," req_only_bridges | ||
| ^ " and block devices only in manifest: " | ||
| ^ String.concat "," mft_only_blocks)) | ||
| | req_only_bridges, req_only_blocks, mft_only_bridges, mft_only_blocks -> |
There was a problem hiding this comment.
I think this could be refactored (e.g. "_ devices missing from manifest", "_ devices only in manifest"), that is, factor out the device type.
… for users to update if needed
I (Reynir) intend to release a new version of solo5-elftool that doesn't depend on owee. In the meantime we pin our owee fork that doesn't depend on Unix.
reynir
requested changes
Jan 31, 2025
While this is very inefficient it is only temporary until changes to ocaml-solo5-elftool are merged and released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the work started in #102 and is related to #54
In this PR, we :
argspassed in the config to albatrossif everything checks out, then we pass this binary to albatross to perform the update.