Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-automatic cSpell pass to detect typos #54

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mbarbin
Copy link
Contributor

@mbarbin mbarbin commented Jan 5, 2025

This is the results of a pass through with cSpell, where I looked briefly at the warnings generated. This is a semi-automatic pass, which would need to be completed by another read at a slower pace. By this I mean that I only went through the warnings that cSpell automatically generated (not the entire text), and then chose manually how to resolve them.

I used a combined en_US & en_GB dictionary, since both conventions seemed to be used in conjunction in the project (e.g. finalizer + finaliser, etc.).

For added context see #50

- This is the results of a pass through with cSpell, where I looked
  briefly at the warnings generated. This is a semi-automatic pass,
  which would need to be completed by another read at a slower pace.
@mbarbin mbarbin marked this pull request as ready for review January 7, 2025 19:57
@mbarbin
Copy link
Contributor Author

mbarbin commented Jan 7, 2025

which would need to be completed by another read at a slower pace

By this I mean some more reading I intend to do outside of the scope of this PR. I have enabled for review.

@dinosaure
Copy link
Contributor

Thanks!

@dinosaure dinosaure merged commit a240782 into robur-coop:main Jan 7, 2025
1 check passed
@mbarbin mbarbin deleted the typos branch January 8, 2025 08:16
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Jan 13, 2025
CHANGES:

- Notice the domain if it needs to look into the shared heap if a task is ready
  to be transfered (@dinosaure, robur-coop/miou#41)
- Don't use `Option.value` but `match .. with` to calculate the optional length
  for `Miou_unix.{read,write}` (@kit-ty-kate, robur-coop/miou#44)
- Use `List.iter` instead of `Hashtbl.iter` for internal kept file-descriptors
  of `Miou_unix` (@dinosaure, robur-coop/miou#45)
- Improve the documentation of `Miou_unix` about suspended syscalls (@dinosaure,
  @kit-ty-kate, robur-coop/miou#43)
- Export `reraise` (@dinosaure, robur-coop/miou#46)
- Fix an issue on the `dom0` and observe if some tasks must be transfered to it
  (@dinosaure, robur-coop/miou#48)
- Fix documentation (@mbarbin, robur-coop/miou#47)
- Fix the formatter (@mbarbin, robur-coop/miou#51)
- Upgrade miou to `ocamlformat.0.27.0` (@mbarbin, robur-coop/miou#52)
- Add `x-maintenance-intent` (@hannesm, robur-coop/miou#56)
- Improve the documentation and some `odoc` warnings (@mbarbin, robur-coop/miou#53, robur-coop/miou#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants