Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New class for return values of interface methods PART3 #3169

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

randaz81
Copy link
Member

sequel of #3167.
All frameTransform interfaces/devices have been updated to use yarp::dev::ReturnValue

@traversaro
Copy link
Member

Hi @randaz81, this PR also changes the canTransform and frameExists methods from taking two arguments to taking three arguments, breaking all the use of these methods, is this change intended?

@randaz81
Copy link
Member Author

Yes, unfortunately this is the only case, so far, which requires one minor changes to apllication code. The yarp tests, which have been modified accordingly, show the correct usage of the new methods.

@traversaro
Copy link
Member

Yes, unfortunately this is the only case, so far, which requires one minor changes to apllication code. The yarp tests, which have been modified accordingly, show the correct usage of the new methods.

Ack! fyi @S-Dafarra the new signature of canTransform and frameExists does not work with bindings as Python/MATLAB does not support output arguments passed as references in C++, so it may be necessary to add new extensions to #3162 to make canTransform and frameExists usable in bindings.

@S-Dafarra
Copy link
Contributor

Would it make sense to deprecate the two methods with the old signature first? This would allow transitioning to the new interface in a cleaner way in downstream code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants