Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Handle CodeEditor Lifecycle #241

Merged
merged 49 commits into from
Mar 20, 2024
Merged

Conversation

tunahanertekin
Copy link
Member

🌿 PR: Handle CodeEditor Lifecycle

Description

CodeEditor owns & manages these resources:

  • n persistent volume claims
  • a deployment for workload
  • a service
  • an ingress (optional)

Closes #231

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How can it be tested?

Can be tested by applying the manifest below:

apiVersion: robot.roboscale.io/v1alpha2
kind: CodeEditor
metadata:
  name: code-editor
  namespace: test
  labels:
    robolaunch.io/cloud-instance: org-development-20772606
    robolaunch.io/cloud-instance-alias: dev-ci-094
    robolaunch.io/domain: robolaunch.cloud
    robolaunch.io/organization: org_development
    robolaunch.io/platform: 0.1.2-prerelease.10
    robolaunch.io/region: eu-central-1
    robolaunch.io/team: org-development-20772606
    robolaunch.io/robot-image-registry: docker.io
spec:
  version: "4.22.0"
  remote: false
  ingress: false
  tlsSecretName: prod-tls
  port: 8000
  serviceType: NodePort
  container:
    volumeMounts:
    - name: code-editor-pvc-0
      mountPath: /testing-mount
  volumeClaimTemplates:
  - spec:
      accessModes:
      - ReadWriteOnce
      resources:
        limits:
          storage: 1Gi
        requests:
          storage: 1Gi

@tunahanertekin tunahanertekin added the enhancement New feature or request label Mar 20, 2024
@tunahanertekin tunahanertekin self-assigned this Mar 20, 2024
@tunahanertekin tunahanertekin linked an issue Mar 20, 2024 that may be closed by this pull request
@tunahanertekin tunahanertekin merged commit 32d32d7 into main Mar 20, 2024
1 check passed
@tunahanertekin tunahanertekin deleted the 231-code-editor-service branch March 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Remote IDE for Production Environments
1 participant