Include reference to block or output introducing error #995
+99
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror; Add block_id to StepExecutionError
grzegorz-roboflow
requested review from
PawelPeczek-Roboflow,
yeldarby,
probicheaux and
hansent
as code owners
| @@ -135,6 +135,8 @@ def safe_execute_step( | |||
| except Exception as error: | |||
| logger.exception(f"Execution of step {step_selector} encountered error.") | |||
| raise StepExecutionError( | |||
| block_id=step_selector, | |||
| block_type=workflow.steps[step_selector.split(".")[-1]].manifest.type, | |||
| public_message=f"Error during execution of step: {step_selector}. Details: {error}", | |||
There was a problem hiding this comment.
Should we update the public message to just {error} instead of "Error during execution of step: {step_selector}. Details: {error}" since we are already sending the step_selector data
There was a problem hiding this comment.
Depends how much do we want to maintain preexisting keys to keep backwards compatibility. I agree remaining keys seem redundant in this context.
There was a problem hiding this comment.
lets change the error message - we send the type of error upstream and we do also provide step selector - putting that inside msg is redundant
inference/core/workflows/execution_engine/v1/compiler/syntactic_parser.py
Show resolved
Hide resolved
PawelPeczek-Roboflow
previously approved these changes
Feb 5, 2025
…y in WorkflowError handler
PawelPeczek-Roboflow
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add blocks_syntax_errors and outputs_syntax_errors to WorkflowSyntaxError
Add block_id to StepExecutionError
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
CI passing
Manually E2E tested
Any specific deployment considerations
N/A
Docs
N/A