Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #1 and should solve the long standing issues of linking on macOS and statically in general.
This is a (potentially) breaking change for several reasons:
MAGIC_DIR
,<TARGET>_MAGIC_DIR
,MAGIC_STATIC
,<TARGET>_MAGIC_STATIC
environment variables are no longer supportedusers need to configure
pkg-config
orvcpkg
insteadlibmagic
needs to be version 5.39 or newerthis is required to have a
libmagic.pc
forpkg-config
, see Use pkg-config #1 (comment)v5-38
and below no longer make sense and need to be removed, see New requirements forlibmagic
,pkg-config
,brew
&vcpkg
#36 (comment)Related issues:
pkg-config
,brew
/vcpkg
on GHA #35 looks at how GitHub Actions could work with those new requirementsThis pull request here does not update the workflows yet
libmagic
,pkg-config
,brew
&vcpkg
#36 looks at the results of the changed crate requirementsUbuntu 20.04.6 LTS Focal Fossa is no longer supported with its default packages
Misc:
pkg-config
crate dependency has a MSRV of v1.30.0, so we don't need to bump oursFollow-up tasks: (not in this pull request)
libmagic
version crate featuressee Remove obsolete
libmagic
version features #47see Make
pkg-config
andvcpkg
default crate features #40see Add and use
setup-libmagic
GitHub Action #41see Add
Cargo.lock
#44see Run CI build workflow on default branch for caching #45
see Build extra CI scenarios #46
see Add CI workflow to test upstream
libmagic
versions #48magic
crate