remove vehicle_moving entity

robinostlund · Dec 5, 2023 · a8674e4 · a8674e4
1 parent 3517ebc
commit a8674e4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/volkswagencarnet/vw_dashboard.py b/volkswagencarnet/vw_dashboard.py
@@ -1082,7 +1082,9 @@ def create_instruments():
             device_class=VWDeviceClass.WINDOW,
             reverse_state=True,
         ),
-        BinarySensor(attr="vehicle_moving", name="Vehicle Moving", device_class=VWDeviceClass.MOVING),
+        ## not used currently, because we only update parkingposition when the last trip's data has changed, because
+        ## of its rate limiting, so this is not reliable at all...
+        # BinarySensor(attr="vehicle_moving", name="Vehicle Moving", device_class=VWDeviceClass.MOVING),
         BinarySensor(attr="request_in_progress", name="Request in progress", device_class=VWDeviceClass.CONNECTIVITY),
     ]
 

diff --git a/volkswagencarnet/vw_vehicle.py b/volkswagencarnet/vw_vehicle.py
@@ -1076,6 +1076,8 @@ def is_position_supported(self) -> bool:
     def vehicle_moving(self) -> bool:
         """Return true if vehicle is moving."""
         # there is not "isMoving" property anymore in VW's API, so we just take the absence of position data as the indicator
+        ## not used currently, because we only update parkingposition when the last trip's data has changed, because
+        ## of its rate limiting, so this is not reliable at all...
         return not is_valid_path(self.attrs, "parkingposition.lat")
 
     @property