Merge pull request #246 from robinostlund/charging_control

Re-enable charging control
robinostlund · Jan 31, 2024 · 7aaaca8 · 7aaaca8
2 parents 29f1a5b + 2cf5b3a
commit 7aaaca8
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 11 deletions.
diff --git a/volkswagencarnet/vw_connection.py b/volkswagencarnet/vw_connection.py
@@ -782,30 +782,35 @@ async def setClimater(self, vin, data, action):
 
     async def setWindowHeater(self, vin, action):
         """Execute window heating actions."""
-
         action = "start" if action else "stop"
-
         try:
             response_raw = await self.post(
                 f"{BASE_API}/vehicle/v1/vehicles/{vin}/windowheating/{action}", json={}, return_raw=True
             )
             return await self._handle_action_result(response_raw)
-
         except Exception as e:
             raise Exception("Unknown error during setWindowHeater") from e
 
+    async def setCharging(self, vin, action):
+        """Execute charging actions."""
+        action = "start" if action else "stop"
+        try:
+            response_raw = await self.post(
+                f"{BASE_API}/vehicle/v1/vehicles/{vin}/charging/{action}", json={}, return_raw=True
+            )
+            return await self._handle_action_result(response_raw)
+        except Exception as e:
+            raise Exception("Unknown error during setCharging") from e
+
     async def setLock(self, vin, lock, spin):
         """Remote lock and unlock actions."""
         await self.check_spin_state()
-
         action = "lock" if lock else "unlock"
-
         try:
             response_raw = await self.post(
                 f"{BASE_API}/vehicle/v1/vehicles/{vin}/access/{action}", json={"spin": spin}, return_raw=True
             )
             return await self._handle_action_result(response_raw)
-
         except Exception as e:
             raise Exception("Unknown error during setLock") from e
 

diff --git a/volkswagencarnet/vw_vehicle.py b/volkswagencarnet/vw_vehicle.py
@@ -281,8 +281,18 @@ async def set_charge_min_level(self, level: int):
         raise Exception("Should have to be re-implemented")
 
     async def set_charger(self, action) -> bool:
-        """Charging actions."""
-        raise Exception("Should have to be re-implemented")
+        """Turn on/off window charging."""
+        if self.is_charging_supported:
+            if action not in ["start", "stop"]:
+                _LOGGER.error(f'Charging action "{action}" is not supported.')
+                raise Exception(f'Charging action "{action}" is not supported.')
+            response = await self._connection.setCharging(self.vin, (action == "start"))
+            return await self._handle_response(
+                response=response, topic="charging", error_msg=f"Failed to {action} charging"
+            )
+        else:
+            _LOGGER.error("No charging support.")
+            raise Exception("No charging support.")
 
     # Climatisation electric/auxiliary/windows (CLIMATISATION)
     async def set_climatisation_temp(self, temperature=20):
@@ -769,9 +779,7 @@ def charging_last_updated(self) -> datetime:
     @property
     def is_charging_supported(self) -> bool:
         """Return true if charging is supported."""
-        # return is_valid_path(self.attrs, f"{Services.CHARGING}.chargingStatus.value.chargingState")
-        # CURRENTLY NOT SUPPORTED
-        return False
+        return is_valid_path(self.attrs, f"{Services.CHARGING}.chargingStatus.value.chargingState")
 
     @property
     def charging_power(self) -> int: