Support multiple ODs #221
Open
Support multiple ODs #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With CAnopenNode v4 some of the ideas of this PR has been included there. I think, this PR is not relevant any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow multiple OD to coexist in CANopenNode, one needs to prefix all constants and variables to avoid duplicate names between the ODs.
Further I have added a const struct filled with constants for the OD.
The prefix are taken from Device Info/Device Commisioning/Node name. This may not be appropriate.
I made a PR to CANopenNode, which, can use the exported code.
Mostly this PR are made to discuss the approach