Make leaflet a peer dependency / webpack external #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertleeplummerjr
added a commit
that referenced
this pull request
Mar 29, 2021
fix: Make Leaflet a peer dependency, from recommendation #99
|
I had started refactoring to a stricter typescript and unit testing over the weekend, and just committed it. However, just before doing so, I implemented your recommendations, TY! I'll close this PR, but awesome recommendation that I tried my best to accredit to you. |
|
No worries, thanks for folding this in @robertleeplummerjr 👍 Just a heads up tho - in current master the leaflet dependency is in both |
|
Fixed and pushed. |
|
Great - looking forward to npm release of |
|
Hi - @robertleeplummerjr curious to know if there will likely be an npm release for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address #98.
Example: