Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major conflicts with other leaflet plugins #98

Open
danwild opened this issue Mar 29, 2021 · 0 comments
Open

Major conflicts with other leaflet plugins #98

danwild opened this issue Mar 29, 2021 · 0 comments

Comments

@danwild
Copy link

danwild commented Mar 29, 2021

I'm not 100% on what is happening here, but when I simply import this plugin alongside other leaflet plugins, things break.

Here's a simple example trying to use Leaflet.glify along side another popular plugin, Leaflet.draw:

Screen Shot 2021-03-29 at 4 56 02 pm

https://gist.github.com/danwild/bad25212abb326b9d55179c4a22ee006

I've also encountered issues when using with leaflet-loading and leaflet-mouse-position.

It seems like there's something funny happening in the dependency tree, the plugins are conflicting somehow.

Potential solution - make leaflet a peer dependency

I noticed that leaflet is listed a direct dependency of this plugin rather than a peer, which sounds like a better fit for a "plugin package".

PR/example to follow.

Cheers,
Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant